Aiofiles import cleanup, fix warnings in pyproject.toml #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix warnings in pyproect.toml
don't redefine builtin functions
|
The HA guys have confirmed my bad import practice is causing the problem - I guess we need to generate a release :( |
|
Can we do a release for this change soon? Looks like all of the PR's are in (and I would like to get the HA PR released). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Reviewing home-assistant/core#108833 I noticed a bit of double importing. This should not change the behavior just tidy things up.
Additionally, received a few warnings from ruff/lint in the pyporject.toml files. Implemented the recommended changes
Related issue (if applicable): fixes #
Checklist:
toxrun successfully PR cannot be meged unless tests pass